Theme JSON: add global block gap css vars #2038
Conversation
…ions for block gap.
| } | ||
| } | ||
|
|
||
| if ( ! empty( $declarations_block_gap ) ) { |
There was a problem hiding this comment.
This is the first attempt, which will be the worst attempt.
Just getting things to work as expected before refactoring.
|
I commented at WordPress/gutenberg#35454 (comment) asking whether this was for WordPress 5.9 or 6.0. If it's the later, we shouldn't port this just yet. |
Thanks a lot @oandregal !! I was just experimenting here, trying to find the best point which we could filter the block class declarations. My hope was to only add something like this in wp-theme-json
and move the logic to the plugin. I am in no way certain that's the right way forward yet so I would be very glad to hear your advice. 😄 |
|
I don't think we want to add low-level filters at the moment. We discussed adding a couple of high-level ones at WordPress/gutenberg#36909 but decided against it. |
Initial commit to test how and where to manipulate the style declarations for block gap.
See: WordPress/gutenberg#35454
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.